Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dnssec keys lookup #1728

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Fix dnssec keys lookup #1728

merged 3 commits into from
Oct 3, 2023

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Oct 3, 2023

Fix dns module with provider version >= 5
hashicorp/terraform-provider-google#16096

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

sruffilli
sruffilli previously approved these changes Oct 3, 2023
View reviewed changes
@juliocc juliocc enabled auto-merge (squash) October 3, 2023 18:50
@juliocc juliocc disabled auto-merge October 3, 2023 19:37
@juliocc juliocc merged commit 4b15605 into master Oct 3, 2023
13 checks passed
@juliocc juliocc deleted the jccb/fix-dns-keys branch October 3, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sruffilli sruffilli sruffilli left review comments

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliocc @sruffilli